Suppress cppcheck unknownMacro #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast forward to ament/ament_lint#268 This suppresses a defect in `ament_cppcheck` - namely that if a macro is missing, it fails loudly. This is compounded by fact that `ament_cppcheck` does not include all dependent headers, so macros are likely to be missing in the first place. Signed-off-by: Dan Rose <dan@digilabs.io>
|
It sure would be nice to see green in the CI again :-) |
Yes! And green it is, yay! |
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Fast forward to ament/ament_lint#268 This suppresses a defect in `ament_cppcheck` - namely that if a macro is missing, it fails loudly. This is compounded by fact that `ament_cppcheck` does not include all dependent headers, so macros are likely to be missing in the first place. Signed-off-by: Dan Rose <dan@digilabs.io>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Fast forward to ament/ament_lint#268 This suppresses a defect in `ament_cppcheck` - namely that if a macro is missing, it fails loudly. This is compounded by fact that `ament_cppcheck` does not include all dependent headers, so macros are likely to be missing in the first place. Signed-off-by: Dan Rose <dan@digilabs.io>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Fast forward to ament/ament_lint#268 This suppresses a defect in `ament_cppcheck` - namely that if a macro is missing, it fails loudly. This is compounded by fact that `ament_cppcheck` does not include all dependent headers, so macros are likely to be missing in the first place. Signed-off-by: Dan Rose <dan@digilabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220
Fast forward to ament/ament_lint#268
This suppresses a defect in
ament_cppcheck- namely that if a macro is missing at checking time, it fails loudly. This is compounded by fact thatament_cppcheckdoes not include all dependent headers, so macros are likely to be missing.Signed-off-by: Dan Rose dan@digilabs.io